Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to fix validation errors and warning #1839

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Update tests to fix validation errors and warning #1839

merged 4 commits into from
Feb 5, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Feb 5, 2024

Motivation

Fix #1838

How to test the behavior?

Run test suite and examine errors and warnings

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from oruebel February 5, 2024 01:03
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b54ba1b) 91.99% compared to head (f8ab15d) 83.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1839      +/-   ##
==========================================
- Coverage   91.99%   83.68%   -8.32%     
==========================================
  Files          27       27              
  Lines        2623     2623              
  Branches      685      685              
==========================================
- Hits         2413     2195     -218     
- Misses        138      344     +206     
- Partials       72       84      +12     
Flag Coverage Δ
integration ?
unit 83.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly enabled auto-merge (squash) February 5, 2024 01:12
@rly rly merged commit 6e970c4 into dev Feb 5, 2024
22 of 23 checks passed
@rly rly deleted the fix_validation branch February 5, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Validation errors in tests when using fixed validator
2 participants