Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs for editing NWB files #1836

Merged
merged 17 commits into from
Jan 31, 2024
Merged

add docs for editing NWB files #1836

merged 17 commits into from
Jan 31, 2024

Conversation

bendichter
Copy link
Contributor

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@bendichter bendichter marked this pull request as draft January 30, 2024 02:09
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c40df49) 91.99% compared to head (31fb465) 91.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1836   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files          27       27           
  Lines        2623     2623           
  Branches      685      685           
=======================================
  Hits         2413     2413           
  Misses        138      138           
  Partials       72       72           
Flag Coverage Δ
integration 71.10% <ø> (ø)
unit 83.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bendichter bendichter requested a review from rly January 30, 2024 02:21
@oruebel
Copy link
Contributor

oruebel commented Jan 30, 2024

@mavaylon1 is also working on a tutorial for this

@bendichter
Copy link
Contributor Author

Where is it?

@bendichter
Copy link
Contributor Author

Thanks for the review, @oruebel. I've made a bunch of these changes. I haven't yet included export, since I don't know its functionality as well, but that's the next step.

@bendichter bendichter marked this pull request as ready for review January 31, 2024 15:03
@bendichter
Copy link
Contributor Author

@oruebel ok, this is ready for another round of review

@oruebel
Copy link
Contributor

oruebel commented Jan 31, 2024

ok, this is ready for another round of review

Overall this looks good to me. I added a few suggestions for minor edits on text, but nothing critical. Feel free to accept/reject the suggestions as necessary.

@rly do you know whether it is possible to change the values of attributes directly in PyNWB. I vaguely remember that PyNWB/HDMF was tracking changes to attribute values so that one can set the values and then call write again on the file to update those values. But I'm not 100% sure whether this is working or if that was just something that we were discussing as a potential feature at some point.

@rly
Copy link
Contributor

rly commented Jan 31, 2024

@rly do you know whether it is possible to change the values of attributes directly in PyNWB. I vaguely remember that PyNWB/HDMF was tracking changes to attribute values so that one can set the values and then call write again on the file to update those values. But I'm not 100% sure whether this is working or if that was just something that we were discussing as a potential feature at some point.

This is not allowed because AbstractContainer prevents all fields from being changed after they are set. We were discussing removing that restriction and replacing it with warnings in hdmf-dev/hdmf#868 but that work is not complete. I ran a few tests here a few months ago to confirm: https://gist.github.com/rly/be7bee420b482b9ddcd084f57cc4115e

@oruebel
Copy link
Contributor

oruebel commented Jan 31, 2024

This is not allowed

Thanks for the clarification. In that case, I think this is good to go.

@bendichter bendichter merged commit b54ba1b into dev Jan 31, 2024
23 of 24 checks passed
@bendichter bendichter deleted the add_docs_editing branch January 31, 2024 22:05
@oruebel
Copy link
Contributor

oruebel commented Jan 31, 2024

Thanks @bendichter ! One thing I missed, we should also make a thumbnail for this tutorial. The PowerPoint file with all the Thumbnail sources is in the repo here https://github.com/NeurodataWithoutBorders/pynwb/blob/dev/docs/source/figures/gallery_thumbnails.pptx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants