Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to sound #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Convert to sound #79

wants to merge 2 commits into from

Conversation

gb0808
Copy link
Contributor

@gb0808 gb0808 commented Aug 28, 2024

This is the convert-to-clip block we talked about in today's meeting.

@dragazo
Copy link
Contributor

dragazo commented Aug 29, 2024

I think this block is not thread safe because lastConvertBlockClip is a global variable rather than a process-owned variable (so concurrent executions of this block by multiple scripts will mess each other up). Also, is this.recordFlag reset elsewhere? Otherwise multiple of these blocks in the same script will not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants