Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gnosis blob fee collection #8091

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Fix Gnosis blob fee collection #8091

merged 4 commits into from
Jan 23, 2025

Conversation

Marchhill
Copy link
Contributor

@Marchhill Marchhill commented Jan 22, 2025

Note: new tests not enabled since we don't have prague timestamp, to see them working check this PR #8095

Changes

  • Ensure blob fee collector is enabled from chainspec
  • Add tests for blob fee collector chainspec configuration

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: tests

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

@Marchhill Marchhill marked this pull request as ready for review January 22, 2025 16:21
@Marchhill Marchhill marked this pull request as draft January 22, 2025 21:48
@Marchhill Marchhill changed the title Gnosis base fee collection chainspec tests Fix Gnosis blob fee collection Jan 23, 2025
@Marchhill Marchhill marked this pull request as ready for review January 23, 2025 11:55
@Marchhill Marchhill merged commit 2d8b87e into master Jan 23, 2025
79 checks passed
@Marchhill Marchhill deleted the test/gnosis-fee-collector branch January 23, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants