Allow users to specify different image registry for helm chart resources and TridentOrchestrator #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasKohout
changed the title
TomasKohout
commented
May 16, 2024
|
Hey @clintonk , if you have time, please have a look. Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Allow users to specify different image registry for helm chart resources and TridentOrchestrator
Project tracking
None
Do any added TODOs have an issue in the backlog?
Nope
Did you add unit tests? Why not?
Not necessary
Does this code need functional testing?
Nope
Is a code review walkthrough needed? why or why not?
Not sure.
Should additional test coverage be executed in addition to pre-merge?
No
Does this code need a note in the changelog?
Yes.
Does this code require documentation changes?
Not sure
Additional Information
This PR allows setting different image registry for helm deployment images and TridentOrchestrator.