Use fully qualified domain image names by default (docker.io) #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is more and more common that Container Runtimes do not resolve unqualified image names to docker.io for various reason. Setting docker.io/ prefix by default does not change the behavior at all but makes the life much easier for teams managing trident on clusters without unqualified image name resolution. This would also prevent deployment errors if an administrator does not pay attention to the image used in the manifests or in helm.
|
Hi @spiarh, Have you submitted a CCLA as indicated in the contributing guidelines? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
It is more and more common that Container Runtimes do not resolve
unqualified image names to docker.io for various reason.
Setting docker.io/ prefix by default does not change the behavior at all
but makes the life much easier for teams managing trident on clusters
without unqaulified image name resolution.
Did you add unit tests? Why not?
Already covered in
utils_test.goDoes this code need functional testing?
Minor change that don't change anything
Is a code review walkthrough needed? why or why not?
I don't think so, there is no logic added at all 😄
Does this code need a note in the changelog?
yes
Does this code require documentation changes?
no, users don't have anything to change or to understand with this change.
Did you add unit tests? Why not?
Already covered in
utils_test.goDoes this code need functional testing?
Minor change that don't change anything
Is a code review walkthrough needed? why or why not?
I don't think so, there is no logic 😄
Does this code need a note in the changelog?
yes
Does this code require documentation changes?
no, users don't have anything to change or to understand with this change.