Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ansible samples #202

Merged
merged 15 commits into from
Nov 1, 2024
Merged

Add ansible samples #202

merged 15 commits into from
Nov 1, 2024

Conversation

kcantrel
Copy link
Collaborator

No description provided.

Copy link
Contributor

github-actions bot commented Oct 30, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Collaborator

@nichollri nichollri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how hard it is but I think adding the volume name along with the volume ID would be valuable in the volume report. I tried to add it myself and broke things.

Also for the README I think it might be nice to have the one link for how to configure AWS which you have but then maybe also a link to a doc on how to install ansible. Maybe there are too many flavors there but was a thought.

Also just a comment but I like at the top of the SnapMirror readme the expected report format is shown, with the fsx inventory report those details are at the bottom. To me it was nicer to see what exactly I am expecting from running this right up front.

Minor but in the readme you say to create a file called secrets_list.csv but in the default at top in generate_report.yaml the default is secrets.csv

For the most part the output of the lag makes sense and you describe it but it was still a little confusing maybe give an example like this and translate it?:
P13DT21H15M50S

@kcantrel
Copy link
Collaborator Author

kcantrel commented Nov 1, 2024

Thanks for the suggestions. I believe I implemented all of them.

Copy link
Collaborator

@nichollri nichollri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great. Retested and all worked as expected.

@nichollri nichollri merged commit 3cec50d into main Nov 1, 2024
10 checks passed
@nichollri nichollri deleted the add_ansible_sample branch November 1, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants