Force Gelu decompose on CPU (#3902)

NervanaSystems · Nov 21, 2019 · f854fd6 · f854fd6
1 parent bcd1f46
commit f854fd6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/ngraph/runtime/cpu/cpu_external_function.cpp b/src/ngraph/runtime/cpu/cpu_external_function.cpp
@@ -1210,7 +1210,8 @@ void runtime::cpu::CPU_ExternalFunction::register_common_passes(
         else if (typeid(ngraph::op::GeluBackpropFactor) == typeid(node))
         {
 #if MKLDNN_VERSION_MAJOR < 1
-            return ((node.input(0).get_element_type() == element::f32) ? true : false);
+            // TODO: (gauri): need to differentiate which implementation : erf vs tanh
+            return false;
 #else
             // TODO: will be supported in mkldnn v1.1
             return false;
@@ -1219,7 +1220,8 @@ void runtime::cpu::CPU_ExternalFunction::register_common_passes(
         else if (typeid(ngraph::op::Gelu) == typeid(node))
         {
 #if MKLDNN_VERSION_MAJOR < 1
-            return ((node.input(0).get_element_type() == element::f32) ? true : false);
+            // TODO: (gauri): need to differentiate which implementation : erf vs tanh
+            return false;
 #else
             // TODO: will be supported in mkldnn v1.1
             return false;

diff --git a/src/ngraph/runtime/cpu/unit_test.manifest b/src/ngraph/runtime/cpu/unit_test.manifest
@@ -22,9 +22,5 @@ lrn_across_nw
 lrn_across_empty
 lrn_6D_across_2_axes
 
-# Gelu tests not supported in CPU backend, we use mkldnn gelubackprop (and not factor)
-gelu_backprop_factor_f32
-backwards_gelu_f32
-
 # ONNX TopK with dynamic K
 top_k_opset_10