Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added translation file #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NeonDmitry
Copy link

Upload auto translation script for skills. 30-32 lines need to be checked for working correctly

Description

Issues

Other Notes

Upload auto translation script for skills
@NeonDmitry NeonDmitry requested a review from NeonDaniel January 13, 2025 15:13
@NeonDmitry NeonDmitry added the documentation Improvements or additions to documentation label Jan 13, 2025
@NeonDmitry
Copy link
Author

@NeonDaniel need only check if it working correct with creating files, point on lines 30-32

python3 translate.py
"""

API_KEY = '6f0f043a-6274-4527-b8fc-95720b03f70c'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be invalidated since its in a public repository. This should be read from envvars like TARGED_LANG

Suggested change
API_KEY = '6f0f043a-6274-4527-b8fc-95720b03f70c'
API_KEY = os.getenv("DEEPL_API_KEY")

"uk-ua"
)

base_folder = "F:/work/skill-weather-dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should read from an envvar

Suggested change
base_folder = "F:/work/skill-weather-dev"
base_folder = os.getenv("SKILL_DIRECTORY")

@@ -0,0 +1,181 @@
import os
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a license notice

Suggested change
import os
# NEON AI (TM) SOFTWARE, Software Development Kit & Application Framework
# All trademark and other rights reserved by their respective owners
# Copyright 2008-2025 Neongecko.com Inc.
# Contributors: Daniel McKnight, Guy Daniels, Elon Gasper, Richard Leeds,
# Regina Bloomstine, Casimiro Ferreira, Andrii Pernatii, Kirill Hrymailo
# BSD-3 License
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are met:
# 1. Redistributions of source code must retain the above copyright notice,
# this list of conditions and the following disclaimer.
# 2. Redistributions in binary form must reproduce the above copyright notice,
# this list of conditions and the following disclaimer in the documentation
# and/or other materials provided with the distribution.
# 3. Neither the name of the copyright holder nor the names of its
# contributors may be used to endorse or promote products derived from this
# software without specific prior written permission.
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
# CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
# EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
# PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA,
# OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
# LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
# NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
import os

Comment on lines +176 to +181
if __name__ == "__main__":
from sys import argv
if len(argv) > 2:
skill_path = argv[1]
else:
skill_path = os.path.dirname(os.path.dirname(__file__))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't appear to actually be used anymore

Suggested change
if __name__ == "__main__":
from sys import argv
if len(argv) > 2:
skill_path = argv[1]
else:
skill_path = os.path.dirname(os.path.dirname(__file__))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants