Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Selective Parsing of Attributes by Tag Name #459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tagoad
Copy link

@tagoad tagoad commented May 5, 2022

Modified Options Builder to include new option - attributeTargetTags - Array
Modified OrderedObjParser to check for attributeTargetTags and see if TagName is in the array

Purpose / Goal

Simple addition to only have attributes parsed from specific TagNames. This need arose from messy source xml where parsing all the attributes complicated and cluttered the resulting JSON. This will allow an array of tag names to be passed into options to filter what tags get their attributes expanded.

This addresses my idea #458. After posting about it, I realized it wouldn't take much to add it so I thought it would be a good chance to make my first commit to a module i like. I hope you like it!

Type

Please mention the type of PR

  • [ ]Bug Fix
  • [ ]Refactoring / Technology upgrade
  • [x]New Feature

Note : Please ensure that you've read contribution guidelines before raising this PR. If your PR is in progress, please prepend [WIP] in PR title. Your PR will be reviewed when [WIP] will be removed from the PR title.

Bookmark this repository for further updates.

Modified Options Builder to include new option - attributeTargetTags - Array
Modified OrderedObjParser to check for attributeTargetTags and see if TagName is in the array
@amitguptagwl
Copy link
Member

Can you please add a few tests for the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants