PR validation, tool config #803
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
standardise format, change name of tests file
new workflow to check commit format and code style against pre-commit config
update pre-commit repo versions and switch black to ruff
version specifier is deprecated
F401 returns linting errors as well as auto-fixes, so this disables the errors and just applies the fixes
docformatter currently can't read from pyproject.toml without tomli
auto reformat with ruff/docformatter/prettier after config changes. This is a huge commit, but shouldn't have any functional changes. Reasons so many files have changed: - prettier hasn't been running for a while, so a lot of js has been reformatted - apparently we still had a lot of double-quoted strings - a lot of imports have been sorted - we were using ":return:" instead of ":returns:" in a lot of places - there were quite a lot of empty or mostly empty (with just a param list) docstrings
|
Abandoning for now to avoid conflicts with preps updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch extension update to add PR validation workflow, standardise/update existing workflows, switch to Ruff, and remove the version specifier from docker-compose.yml.