Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a page about being a DataCite service provider #736

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

jrdh
Copy link
Member

@jrdh jrdh commented Dec 6, 2023

Adds a page to explain that we're a DataCite service provider.

Here's what it looks like wide

image

Here's what it looks like on a small screen

image

@jrdh jrdh self-assigned this Dec 6, 2023
Copy link
Member

@alycejenni alycejenni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be using class="external" on the links? (I don't actually know if we're consistent with this everywhere else so it may not be worth it)

@jrdh
Copy link
Member Author

jrdh commented Dec 6, 2023

I honestly have no idea! I expect we are not consistent but I can change them, might as well.

@coveralls
Copy link

coveralls commented Dec 6, 2023

Coverage Status

coverage: 32.945% (+0.04%) from 32.901%
when pulling 8784fca on josh/datacite_page
into a2dc665 on dev.

@jrdh jrdh merged commit cebc3a1 into dev Dec 11, 2023
1 check passed
@jrdh jrdh deleted the josh/datacite_page branch December 11, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants