Simplify the OpenRC init script and conf file #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit largely rewrites the OpenRC init script with the goal of
simplifying it. The end result should be functionally the same, but is
much shorter. The changes are as follows:
1. Replace the deprecated /sbin/runscript shebang with /sbin/openrc-run.
2. Replace the existing dependencies with "need mysql nagios". The
ndo2db daemon needs Nagios to create the TCP or Unix socket over
which it will communicate, and obviously it needs mysql to be
up and running in order to save any data. The dependencies
of mysql and nagios themselves will bring up whatever else is
required; nothing else needs to be listed as a dependency of
ndo2db.
3. Use the "command", "command_args", and "pidfile" OpenRC
variables. OpenRC is smart enough to start and stop a well-behaved
daemon on its own without a custom start/stop function. By
specifying those three variables, we are able to eliminate much of
the custom start/stop code in the init script.
Finally, the default value of NDO2DB_CFG in the associated conf file has
been updated to use @sysconfdir@ instead of @pkgsysconfdir@, which wasn't
having any effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit message does some explaining. We've had this patch in Gentoo for a long time. While I hate to use this argument, I'm the Gentoo maintainer for ndoutils, and I wrote the OpenRC service script guide, so unless you know someone else who uses OpenRC, you should probably just trust me :)