Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 921600 cpc baudrate. #93

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

BrianPugh
Copy link

Adds an option to set CPC baudrate to 921600. I haven't had an opportunity to test this on hardware (I don't want to develop on the zigbee stick that's running my house), but no reason it shouldn't work.

Follow up on Nerivec/ember-zli#12 .

@puddly
Copy link
Collaborator

puddly commented Jan 11, 2025

You can specify the CPC baudrate over CLI via --cpc-baudrate 921600 if your firmware uses a different baudrate.

The default baudrates are iterated over, one at a time, every time an adapter is probed. Each new option unfortunately slows down probing so I don't think this will be a good change to have globally.

@Nerivec
Copy link

Nerivec commented Jan 11, 2025

A better option might be to make the params available through the web flasher (advanced section or something)?

@puddly
Copy link
Collaborator

puddly commented Jan 11, 2025

The baudrate config is exposed in the manifest.json so any deployment can add it to the list: https://connectzbt1.home-assistant.io/firmwares/manifest.json

@Nerivec
Copy link

Nerivec commented Jan 11, 2025

I was thinking more in a way that allows to set the baudrate directly to avoid the probing entirely (same for type), from within the web flasher. But since the config allows probing customization (partly solving the original issue), that'd be more of a new "feature" to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants