-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow PRs to build images #54
Conversation
Should be good now. Took a very long time to figure out that pushing changes to a fork triggers |
I've brought build times down to about 5 minutes for the base Docker container by downloading the release ZIPs instead of checking out the SDK repos with Git. Firmwares build in about 30s each (in parallel), after 2 minutes is spent pulling the above container. Tested with an unreleased PR bumping Gecko SDK: https://github.com/puddly/silabs-firmware-builder/actions/runs/8940084401 |
Nice! |
This PR makes the container building step optional, allowing PRs that modify both to be done in two stages:
Dockerfile
Since no write access is granted to the container for non-members, it can be used by normal PRs within CI (after approval).