Add timeout and test environment app.import call #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for labs-zap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
TylerMatteo
changed the title
|
@pratishta mind approving if it looks good to you? David and I both have commits so don't want to be approvers. |
dhochbaum-dcp
force-pushed
the
tm-fix-tests
branch
from
2f4b5c5 to
96363ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are intended to resolve two different errors we've been having with running tests for this repo.
testem.jsfix an error seen sporadically referring to a timeout being reached. This error would manifest with a reference to Testem not being loadedember-cli-buildis meant to fix the error seen since Pratishta/subscribe #1563 was merged in. As far as I can tell, this error was due to foundation not being imported when the app was run intestmode. This seems to have fixed that but not 100% sure.Tests now execute successfully but fail. The error I'm seeing says "Assertion Failed: Attempted to register a view with an id already in use". My working theory is that this is due to use of Foundations modal component introduced in #1559, based on a similar Issue found in Ember's repo.
I'd like to merge this in to fix the existing issues, knowing the tests still fail, then have @dhochbaum-dcp investigate the new error.