-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to disable disable measuring kudo buffer copy. #2759
base: branch-25.02
Are you sure you want to change the base?
Add an option to disable disable measuring kudo buffer copy. #2759
Conversation
Signed-off-by: Renjie Liu <[email protected]>
Signed-off-by: Renjie Liu <[email protected]>
build |
build |
Just out of curiosity, how expensive is System.nanoTime with relative to the actual memory copy? The code change itself looks good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please tie this into visibility of the copy buffer time metric? If this is off, but the metric still shows up on the UI it will be confusing for customers.
Hi, @revans2 I've submitted a pr to hide it in spark rapids: NVIDIA/spark-rapids#11996 The whole issue has been splitted into three steps, see NVIDIA/spark-rapids#11995 |
We have observed about 30% improvement in actual workload, where partition is quite small. |
When used in shuffle cases with large partition numbers, each call to
System.nanoTime
is still quite expensive compared with a small memory copy. This pr adds an option to disable this measurement and disable it by default.