Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dlwp_healpix constant coupler batch inference #685

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ivanauyeung
Copy link
Contributor

Modulus Pull Request

Description

Fix the bug where dlwp_healpix constant coupler did not support batch coupled inputs for inference

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@dallasfoster
Copy link
Collaborator

What test covers this change?

@yairchn
Copy link
Collaborator

yairchn commented Sep 25, 2024

@ivanauyeung
I tested successfully the inference of ensemble forecast with this PR.
However, do we know this works in training? have you tested that?

@ivanauyeung
Copy link
Contributor Author

The function set_coupled_fields in the coupler.py is only used in the inference stage. So these changes will not affect the training. Also, tests are added to cover this function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants