Allow users to pass in a variable number of channels. #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would open the door for block functions to operate on multiple channels of the VDB, reading from one and writing to another etc. The templates ensure that the change is backwards compatiable. Signed-off-by: Aspen Eyers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Just a suggestion, but I can see this being quite useful.
If you pass the rayCast method in a pointer to the channel to operate on instead of the channel, then you can
open the door for block functions to operate on multiple channels of the VDB, reading from one and writing to another etc.
I've tried to ensure that the change is backwards compatible by templating the old behaviour.
Signed-off-by: Aspen Eyers [email protected]