Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default decoder float type to double #31

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Change default decoder float type to double #31

merged 3 commits into from
Dec 17, 2024

Conversation

bmhowe23
Copy link
Collaborator

  1. Change default decoder float type to double.
  2. Define equality and inequality operators for decoder_result.
  3. Cleanup CMakeLists.txt to use var instead of repeated name.

wsttiger
wsttiger approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@wsttiger wsttiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmhowe23 bmhowe23 merged commit 57b5e5c into NVIDIA:main Dec 17, 2024
13 checks passed
@bmhowe23 bmhowe23 deleted the pr-update-decoder-interface branch December 17, 2024 00:34
justinlietz pushed a commit to justinlietz/cudaqx that referenced this pull request Jan 16, 2025
@bmhowe23 @justinlietz
Change default decoder float type to double (NVIDIA#31)
7b256a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsttiger wsttiger wsttiger approved these changes

@amccaskey amccaskey Awaiting requested review from amccaskey

@justinlietz justinlietz Awaiting requested review from justinlietz

@melody-ren melody-ren Awaiting requested review from melody-ren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmhowe23 @wsttiger