Implement Github CI #84
Conversation
| - setuptools | ||
| - wheel | ||
| - pip | ||
| - cuda-version >= 12.6 |
There was a problem hiding this comment.
What happens if we use CUDA X.(Y+1) to compile cuda-python CUDA X.Y? (i.e. use a newer CUDA to compile an older cuda-python)?
There was a problem hiding this comment.
I don't think it's supported. As per documentation cuda-python X.Y needs to be compiled with cuda toolkit X.Y.
There was a problem hiding this comment.
So then this will fail as soon as CUDA 12.7 binaries are released.
I'm not sure how you want to keep this in line if cuda-python doesn't get released at the same time.
There was a problem hiding this comment.
@sandeepd-nv should this be = 12.6 instead of >=12.6?
There was a problem hiding this comment.
Set to 12.6 exactly.
…tup action since actions are available only after the source code has been checked out.
.github/actions/build/action.yml.j2
Outdated
| required: true | ||
| inter-repos-ro-access-token: | ||
| type: string | ||
| required: true |
There was a problem hiding this comment.
What if you don't need access to any other repos?
.github/actions/build/action.yml.j2
Outdated
| target-device: | ||
| required: true | ||
| type: string | ||
| platform: |
There was a problem hiding this comment.
is this host_platform or target_platform?
There was a problem hiding this comment.
Host platform. Updated.
| @@ -0,0 +1,24 @@ | |||
| name: cupy | |||
There was a problem hiding this comment.
cupy is actually a completely separate project, can you rename this to something else? e.g. cuda_python or build_env or anything else that makes sense here?
There was a problem hiding this comment.
Changed to cuda_python.
.github/actions/setup/action.yml
Outdated
| target-device: | ||
| required: true | ||
| type: string | ||
| platform: |
There was a problem hiding this comment.
Similar question as above. Is this host or target platform?
| channels: | ||
| - defaults | ||
| dependencies: | ||
| - python=3.11 |
There was a problem hiding this comment.
Will this conflict if you're building PYTHON_VERSION=3.10? or any non-py311 version?
There was a problem hiding this comment.
Should work with 3.10 but I have changed the constraint to >=3.10.
| @@ -0,0 +1,258 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| set_darwin_build_env() { | |||
There was a problem hiding this comment.
All of the Darwin related functions can be removed.
No description provided.