Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Fix the latest docs with more fine-grained warning banners #411

Merged
merged 2 commits into from
Jan 20, 2025
Merged

CI: Fix the latest docs with more fine-grained warning banners #411

merged 2 commits into from
Jan 20, 2025

Conversation

leofang
Copy link
Member

@leofang leofang commented Jan 20, 2025

Follow-up of #410. Turns out we broke the latest docs https://nvidia.github.io/cuda-python/latest/. This PR adds more fine-grained warning banners to fix it:

@leofang leofang added bug Something isn't working documentation Improvements or additions to documentation P0 High priority - Must do! CI/CD CI/CD infrastructure labels Jan 20, 2025
@leofang leofang added this to the cuda-python 12-next, 11-next milestone Jan 20, 2025
@leofang leofang requested a review from ksimpson-work January 20, 2025 19:47
@leofang leofang self-assigned this Jan 20, 2025
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 20, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang mentioned this pull request Jan 20, 2025
Merged
@leofang
Copy link
Member Author

leofang commented Jan 20, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 20, 2025

/ok to test

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@leofang leofang enabled auto-merge (squash) January 20, 2025 20:33
@leofang leofang merged commit 023c4bf into NVIDIA:main Jan 20, 2025
69 checks passed
@leofang leofang deleted the fix_preview branch January 20, 2025 20:59
@github-actions GitHub Actions
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

@leofang
Copy link
Member Author

leofang commented Jan 20, 2025

It's fixed now: 5aebbd6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksimpson-work ksimpson-work ksimpson-work approved these changes

Assignees

@leofang leofang

Labels
bug Something isn't working CI/CD CI/CD infrastructure documentation Improvements or additions to documentation P0 High priority - Must do!
Projects
None yet
Milestone
cuda-python 12.8.0 & 11.8.6
Development

Successfully merging this pull request may close these issues.
2 participants
@leofang @ksimpson-work