Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix fetching the latest commit from the backport branch #384

Merged
merged 2 commits into from
Jan 12, 2025

Conversation

leofang
Copy link
Member

@leofang leofang commented Jan 12, 2025

Turns out #381 was only a partial fix and I should have run the full CI there 😞 This PR replaces it with a better fix to avoid failures seen in the main branch:
https://github.com/NVIDIA/cuda-python/actions/runs/12736445625
where the LATEST_PRIOR_RUN_ID is empty due to the extra quotation added in #381.

@leofang leofang added P0 High priority - Must do! CI/CD CI/CD infrastructure labels Jan 12, 2025
@leofang leofang self-assigned this Jan 12, 2025
Copy link

copy-pr-bot bot commented Jan 12, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented Jan 12, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 12, 2025

Let me add the backport label and admin-merge to test the backport CI. It should leave a comment in this PR to report an error.

@leofang leofang added the to-be-backported Trigger the bot to raise a backport PR upon merge label Jan 12, 2025
@leofang leofang merged commit c09e914 into NVIDIA:main Jan 12, 2025
81 checks passed
@leofang leofang deleted the fix_last_commit_fetch branch January 12, 2025 22:09
Copy link

Backport failed for 11.8.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 11.8.x
git worktree add -d .worktree/backport-384-to-11.8.x origin/11.8.x
cd .worktree/backport-384-to-11.8.x
git switch --create backport-384-to-11.8.x
git cherry-pick -x aa880355e6d31fa2e7a69e7e15f5561c4417d8a9 9bcf9d665bfc047a7e9a764a74ec2e61d29aa01e

@leofang leofang added bug Something isn't working and removed to-be-backported Trigger the bot to raise a backport PR upon merge labels Jan 12, 2025
Copy link

Backport failed for 11.8.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 11.8.x
git worktree add -d .worktree/backport-384-to-11.8.x origin/11.8.x
cd .worktree/backport-384-to-11.8.x
git switch --create backport-384-to-11.8.x
git cherry-pick -x aa880355e6d31fa2e7a69e7e15f5561c4417d8a9 9bcf9d665bfc047a7e9a764a74ec2e61d29aa01e

@leofang
Copy link
Member Author

leofang commented Jan 13, 2025

This PR replaces it with a better fix to avoid failures seen in the main branch

this is now fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI/CD CI/CD infrastructure P0 High priority - Must do!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant