Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI status check #379

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Add CI status check #379

merged 1 commit into from
Jan 12, 2025

Conversation

leofang
Copy link
Member

@leofang leofang commented Jan 12, 2025

Close #377.

@leofang leofang self-assigned this Jan 12, 2025
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 12, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@leofang leofang added P0 High priority - Must do! CI/CD CI/CD infrastructure labels Jan 12, 2025
@leofang leofang added this to the cuda-python 12-next, 11-next milestone Jan 12, 2025
@leofang
Copy link
Member Author

leofang commented Jan 12, 2025

/ok to test

@leofang leofang marked this pull request as draft January 12, 2025 01:57
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 12, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented Jan 12, 2025

/ok to test

@leofang leofang marked this pull request as ready for review January 12, 2025 02:19
@leofang
Copy link
Member Author

leofang commented Jan 12, 2025

/ok to test

@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 12, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented Jan 12, 2025

/ok to test

@leofang leofang added the to-be-backported Trigger the bot to raise a backport PR upon merge label Jan 12, 2025
@leofang
Copy link
Member Author

leofang commented Jan 12, 2025

Let me admin-merge this because this is only the 1st step; the 2nd step is to add the check status job name to the repo branch rule so that it's honored by GitHub UI. After confirming this works, I'll backport the PR.

@leofang leofang merged commit ece3281 into NVIDIA:main Jan 12, 2025
49 checks passed
@leofang leofang deleted the status_check branch January 12, 2025 03:55
@leofang leofang mentioned this pull request Jan 12, 2025
Closed
@leofang
Copy link
Member Author

leofang commented Jan 12, 2025

Let me admin-merge this because this is only the 1st step; the 2nd step is to add the check status job name to the repo branch rule so that it's honored by GitHub UI. After confirming this works, I'll backport the PR.

It works: #377 (comment). Let me backport...

@leofang
Copy link
Member Author

leofang commented Jan 12, 2025

I noticed that the backport CI is supposed to send an error message but it did not, because of an error:

Error: The template is not valid. .github/workflows/backport.yml (Line: 36, Col: 28): Input string '11.8.x' is not a valid number. Path '', line 1, position 6.

https://github.com/NVIDIA/cuda-python/actions/runs/12730243631/job/35482964722
I'll fix it.

This was referenced Jan 12, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@leofang leofang

Labels
CI/CD CI/CD infrastructure P0 High priority - Must do! to-be-backported Trigger the bot to raise a backport PR upon merge
Projects
None yet
Milestone
cuda-python 12-next, 11-next
Development

Successfully merging this pull request may close these issues.

CI: Require all checks passing before merging
1 participant
@leofang