document the buildtime environment variables #374
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksimpson-work
requested review from
vzhurba01 and
leofang
and removed request for
vzhurba01
ksimpson-work
commented
Jan 10, 2025
| @@ -308,9 +315,9 @@ def build_extension(self, ext): | |||
| # Allow extensions to discover libraries at runtime | |||
| # relative their wheels installation. | |||
| if ext.name == "cuda.bindings._bindings.cynvrtc": | |||
| ldflag = f"-Wl,--disable-new-dtags,-rpath,$ORIGIN/../../../nvidia/cuda_nvrtc/lib" | |||
There was a problem hiding this comment.
it would appear this file escaped ruff linting in a previous commit
leofang
requested changes
Jan 12, 2025
| DeprecationWarning, | ||
| stacklevel=1, | ||
| ) | ||
| nthreads = int(os.environ.get("CUDA_PYTHON_PARALLEL_LEVEL", "0") or "0") |
There was a problem hiding this comment.
This treatment ignored PARALLEL_LEVEL, so it means PARALLEL_LEVEL is not deprecated but removed.
| @@ -46,6 +46,12 @@ During the build process, environment variable `CUDA_HOME` or `CUDA_PATH` are us | |||
| export CUDA_HOME=/usr/local/cuda | |||
| ``` | |||
|
|
|||
| Some other build time environment variables are as follows: | |||
There was a problem hiding this comment.
Could you create a new page "environment variables", move the text there & also add run-time env vars, and link it to index.rst & cross-ref it here? This way we have env vars easily findable on table of contents. Right now you have to know what you're looking for.
leofang
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #106
WIP see question added to issue #106