Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document header requirements for Cython users #372

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Document header requirements for Cython users #372

merged 3 commits into from
Jan 15, 2025

Conversation

vzhurba01
Copy link
Collaborator

close #245

@vzhurba01 vzhurba01 added documentation Improvements or additions to documentation P0 High priority - Must do! cuda.bindings Everything related to the cuda.bindings module labels Jan 10, 2025
@vzhurba01 vzhurba01 self-assigned this Jan 10, 2025
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 10, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vzhurba01
Copy link
Collaborator Author

/ok to test

@vzhurba01 vzhurba01 force-pushed the doc-cython-layer-requirements branch from 0627572 to f33051a Compare January 10, 2025 00:32
@leofang
Copy link
Member

leofang commented Jan 10, 2025

/ok to test

leofang
leofang reviewed Jan 10, 2025
View reviewed changes
cuda_bindings/docs/source/install.md Outdated Show resolved Hide resolved
cuda_bindings/docs/source/install.md Outdated Show resolved Hide resolved
cuda_bindings/docs/source/install.md Outdated Show resolved Hide resolved
cuda_bindings/docs/source/install.md Outdated Show resolved Hide resolved
cuda_bindings/docs/source/install.md Outdated Show resolved Hide resolved
cuda_bindings/docs/source/install.md Outdated Show resolved Hide resolved
cuda_bindings/docs/source/install.md Outdated Show resolved Hide resolved
cuda_bindings/docs/source/install.md Outdated Show resolved Hide resolved
cuda_bindings/docs/source/install.md Outdated Show resolved Hide resolved
ksimpson-work
ksimpson-work reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@ksimpson-work ksimpson-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits. I didn't see anything significant that Leo didn't already mention in his review

cuda_bindings/docs/source/install.md Outdated Show resolved Hide resolved
cuda_bindings/docs/source/install.md Outdated Show resolved Hide resolved
cuda_bindings/docs/source/install.md Outdated Show resolved Hide resolved
@vzhurba01 vzhurba01 mentioned this pull request Jan 14, 2025
Merged
@vzhurba01
Copy link
Collaborator Author

/ok to test

@vzhurba01 vzhurba01 force-pushed the doc-cython-layer-requirements branch from e4f8509 to 083347c Compare January 15, 2025 00:42
@vzhurba01
Copy link
Collaborator Author

/ok to test

@leofang leofang merged commit ee8d7cd into NVIDIA:main Jan 15, 2025
79 checks passed
@github-actions GitHub Actions
Copy link

Backport failed for 11.8.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 11.8.x
git worktree add -d .worktree/backport-372-to-11.8.x origin/11.8.x
cd .worktree/backport-372-to-11.8.x
git switch --create backport-372-to-11.8.x
git cherry-pick -x 0bd559b0d2b6d19cd04e9dd52e20a839ae2967b4 fd60a05b95742c386b75a3c430324849ddd09d23 083347c6d771b74af94629eaa368bec16fae5022

1 similar comment
@github-actions GitHub Actions
Copy link

Backport failed for 11.8.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 11.8.x
git worktree add -d .worktree/backport-372-to-11.8.x origin/11.8.x
cd .worktree/backport-372-to-11.8.x
git switch --create backport-372-to-11.8.x
git cherry-pick -x 0bd559b0d2b6d19cd04e9dd52e20a839ae2967b4 fd60a05b95742c386b75a3c430324849ddd09d23 083347c6d771b74af94629eaa368bec16fae5022

@leofang leofang mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksimpson-work ksimpson-work ksimpson-work left review comments

@leofang leofang leofang approved these changes

Assignees

@vzhurba01 vzhurba01

Labels
cuda.bindings Everything related to the cuda.bindings module documentation Improvements or additions to documentation P0 High priority - Must do!
Projects
None yet
Milestone
cuda-python 12.8.0 & 11.8.6
Development

Successfully merging this pull request may close these issues.

Document requirements for using bindings at the Cython layer
3 participants
@vzhurba01 @leofang @ksimpson-work