Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up a preliminary doc build/publish pipeline #325

Merged
merged 21 commits into from
Jan 2, 2025
Merged

Set up a preliminary doc build/publish pipeline #325

merged 21 commits into from
Jan 2, 2025

Conversation

leofang
Copy link
Member

@leofang leofang commented Dec 28, 2024

For now this only updates the "latest" docs, reflecting the changes made in the main branch. This is consistent with the behavior of most versioned docs.

Part of #169.

@leofang leofang added documentation Improvements or additions to documentation P0 High priority - Must do! CI/CD CI/CD infrastructure labels Dec 28, 2024
@leofang leofang added this to the cuda.core beta 3 milestone Dec 28, 2024
@leofang leofang self-assigned this Dec 28, 2024
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Dec 28, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented Dec 28, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 28, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 28, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 28, 2024

/ok to test

1 similar comment
@leofang
Copy link
Member Author

leofang commented Dec 28, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 28, 2024

/ok to test

1 similar comment
@leofang
Copy link
Member Author

leofang commented Dec 28, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 28, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 28, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 28, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 28, 2024

This is ready for review (after the holidays!). The PR status is set to draft only because of #325 (comment).

@leofang leofang mentioned this pull request Dec 28, 2024
Merged
@leofang
Copy link
Member Author

leofang commented Dec 28, 2024

/ok to test

@leofang leofang marked this pull request as ready for review December 28, 2024 23:59
@leofang
Copy link
Member Author

leofang commented Dec 29, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 30, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 30, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Jan 2, 2025

This is ready for review/merge.

ksimpson-work
ksimpson-work reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@ksimpson-work ksimpson-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little question about the CI cancellation, otherwise LGTM

.github/workflows/build-and-test.yml Show resolved Hide resolved
@ksimpson-work ksimpson-work self-requested a review January 2, 2025 19:06
@leofang
Copy link
Member Author

leofang commented Jan 2, 2025

Thanks, Keenan! Let's merge and I'll check if the pipeline works and updates the docs. If not I'll look into it.

@leofang leofang merged commit 2ebacd6 into NVIDIA:main Jan 2, 2025
@leofang leofang deleted the doc branch January 2, 2025 19:15
@leofang leofang linked an issue Jan 3, 2025 that may be closed by this pull request
Set up a doc-build pipeline to auto-publish doc changes #169
Closed
@leofang leofang mentioned this pull request Jan 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksimpson-work ksimpson-work ksimpson-work approved these changes

@vzhurba01 vzhurba01 Awaiting requested review from vzhurba01

@sandeepd-nv sandeepd-nv Awaiting requested review from sandeepd-nv

Assignees

@leofang leofang

Labels
CI/CD CI/CD infrastructure documentation Improvements or additions to documentation P0 High priority - Must do!
Projects
None yet
Milestone
cuda.core beta 3
Development

Successfully merging this pull request may close these issues.

Set up a doc-build pipeline to auto-publish doc changes
2 participants
@leofang @ksimpson-work