Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document all available build-time and run-time environment variables #106

Open
leofang opened this issue Sep 16, 2024 · 3 comments · May be fixed by #374
Open

Document all available build-time and run-time environment variables #106

leofang opened this issue Sep 16, 2024 · 3 comments · May be fixed by #374
Assignees
Labels
cuda.bindings Everything related to the cuda.bindings module documentation Improvements or additions to documentation P1 Medium priority - Should do

Comments

@leofang
Copy link
Member

leofang commented Sep 16, 2024

We should also rename PARALLEL_LEVEL to, e.g., CUDA_PYTHON_PARALLEL_LEVEL

nthreads = int(os.environ.get("PARALLEL_LEVEL", "0") or "0")

@leofang leofang added documentation Improvements or additions to documentation P1 Medium priority - Should do labels Sep 16, 2024
@github-actions github-actions bot added the triage Needs the team's attention label Sep 16, 2024
@leofang leofang removed the triage Needs the team's attention label Sep 16, 2024
@leofang
Copy link
Member Author

leofang commented Sep 26, 2024

related: #133 (CUDA_PYTHON_CUDA_PER_THREAD_DEFAULT_STREAM)

@leofang leofang added this to the cuda-python 12-next, 11-next milestone Oct 10, 2024
@leofang leofang added the cuda.bindings Everything related to the cuda.bindings module label Oct 10, 2024
@ksimpson-work
Copy link
Contributor

I am naively addressing the list of environment variables I have found referenced in the codebase by grepping os.environ.get(. Is there a list or source of truth I can look at which documents other variables that we want to document which aren't explicitely queried in our .py source files? The list I currently have is short:

CUDA_PATH / CUDA_HOME
CUDA_PYTHON_PARALLEL_LEVEL
CUDA_PYTHON_PARSER_CACHING
CUDA_PYTHON_DOMAIN

@ksimpson-work ksimpson-work linked a pull request Jan 10, 2025 that will close this issue
@leofang
Copy link
Member Author

leofang commented Jan 12, 2025

  • CUDA_PATH/CUDA_HOME: build-time only
  • CUDA_PYTHON_PARALLEL_LEVEL: build-time only
  • CUDA_PYTHON_PARSER_CACHING: build-time only
  • CUDA_PYTHON_CUDA_PER_THREAD_DEFAULT_STREAM: run-time only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda.bindings Everything related to the cuda.bindings module documentation Improvements or additions to documentation P1 Medium priority - Should do
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants