Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCCLAllocator: Fix build failure #1818

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Aidyn-A
Copy link
Collaborator

@Aidyn-A Aidyn-A commented Jul 19, 2024

This PR adds shareIpcHandle to NCCLAllocator to satisfy its base class definition CUDAAllocator which has recently changed (pytorch/pytorch#130888).

cc @xwang233

@crcrpar
Copy link
Collaborator

crcrpar commented Jul 19, 2024

Q: what would happen if I build this with pytorch prior without the linked pr merged?

@Aidyn-A
Copy link
Collaborator Author

Aidyn-A commented Jul 19, 2024

Q: what would happen if I build this with pytorch prior without the linked pr merged?

It will fail because ShareableHandle struct gets defined only in that PR 😒

@xwang233
Copy link
Contributor

Q: what would happen if I build this with pytorch prior without the linked pr merged?

I think we can guard against TORCH_VERSION (or similar macro) for 2.5. Torch 2.4 will be released soon and won't have this field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants