Updated preprocess_text.py to fix NeMo-text-processing :: WARNING :: Your input is too long and could take a long time to normalize. Use split_text_into_sentences() to make the input shorter and then call normalize_list(). #11780
+56
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for this warning: NeMo-text-processing :: INFO :: Creating ClassifyFst grammars. 0%| | 0/8 [00:00<?, ?it/s] NeMo-text-processing :: WARNING :: Your input is too long and could take a long time to normalize. Use split_text_into_sentences() to make the input shorter and then call normalize_list(). NeMo-text-processing :: WARNING :: Your input is too long and could take a long time to normalize. Use split_text_into_sentences() to make the input shorter and then call normalize_list(). NeMo-text-processing :: WARNING :: Your input is too long and could take a long time to normalize. Use split_text_into_sentences() to make the input shorter and then call normalize_list(). NeMo-text-processing :: WARNING :: Your input is too long and could take a long time to normalize. Use split_text_into_sentences() to make the input shorter and then call normalize_list(). Solution is seen below in Explanation of changes. Explanation of Changes: 1. Splitting Long Sentences: After initially splitting the text into sentences, the script iterates through each sentence to check if it exceeds 500 words. If it does, the sentence is further split into smaller chunks of 500 words each. 2. Logging for Debugging: The script logs a warning if any sentence still exceeds 500 words after the splitting process. This helps in identifying if the splitting logic needs further refinement. 3. Normalization: Each split sentence is normalized individually. After normalization, the sentences are concatenated back into a single string. Signed-off-by: Adesoji Alu <[email protected]>
Signed-off-by: Adesoji1 <[email protected]>
Fix for this warning: NeMo-text-processing :: INFO :: Creating ClassifyFst grammars.
0%| | 0/8 [00:00<?, ?it/s] NeMo-text-processing :: WARNING :: Your input is too long and could take a long time to normalize. Use split_text_into_sentences() to make the input shorter and then call normalize_list().
NeMo-text-processing :: WARNING :: Your input is too long and could take a long time to normalize. Use split_text_into_sentences() to make the input shorter and then call normalize_list().
NeMo-text-processing :: WARNING :: Your input is too long and could take a long time to normalize. Use split_text_into_sentences() to make the input shorter and then call normalize_list().
NeMo-text-processing :: WARNING :: Your input is too long and could take a long time to normalize. Use split_text_into_sentences() to make the input shorter and then call normalize_list(). Solution is seen below in Explanation of changes.
Explanation of Changes:
Splitting Long Sentences:
After initially splitting the text into sentences, the script iterates through each sentence to check if it exceeds 500 words. If it does, the sentence is further split into smaller chunks of 500 words each.
Logging for Debugging:
The script logs a warning if any sentence still exceeds 500 words after the splitting process. This helps in identifying if the splitting logic needs further refinement.
Normalization:
Each split sentence is normalized individually. After normalization, the sentences are concatenated back into a single string.
Signed-off-by: Adesoji Alu <[email protected]>
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Mitigation guide:
By applying these rules, we reduce the occurance of this message in future. Thank you for improving NeMo's documentation! |
Sure i will, @XuesongYang @titu1994 kindly view my PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information