Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to symlink from remote dir in packager #122

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

hemildesai
Copy link
Collaborator

Example usage of interface:

reuse_dir = exp.tunnels[ssh_tunnel.key].packaging_jobs["my-test-run"].dst_path
if reuse_dir:
     executor.packager.symlink_from_remote_dir = reuse_dir

Interface can be changed if needed.

@hemildesai hemildesai requested a review from Kipok December 13, 2024 06:02
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Signed-off-by: Hemil Desai <[email protected]>
Copy link
Collaborator

@Kipok Kipok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works great!

@@ -45,6 +45,10 @@ class Packager(ConfigurableMixin):
#: Uses component or executor specific debug flags if set to True.
debug: bool = False

#: Symlinks the package from the provided remote dir.
#: Only applicable when using SlurmExecutor at the moment.
symlink_from_remote_dir: Optional[str] = None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to do the same for local runs as well. But not as important as current changes, so we can keep it in the backlog

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #126

@hemildesai hemildesai merged commit b4e2258 into main Dec 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants