Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable HA CI tests #3097

Merged
merged 11 commits into from
Jan 22, 2025
Merged

Disable HA CI tests #3097

merged 11 commits into from
Jan 22, 2025

Conversation

YuanTingHsieh
Copy link
Collaborator

Description

  • Disable HA tests as the current impl. is obsolete
  • Make master_template consistent (in nvflare/lighter/templates/master_template.yml and nvflare/lighter/impl/master_template.yml)

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh added the cicd continuous integration/continuous development label Dec 10, 2024
@YuanTingHsieh
Copy link
Collaborator Author

/build

SYangster
SYangster previously approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@SYangster SYangster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanTingHsieh
Copy link
Collaborator Author

/build

@chesterxgchen
Copy link
Collaborator

@YuanTingHsieh can you get this conflict fixed and get PR merged when you get a chance

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh changed the title Fix ci tests Disable HA CI tests Jan 10, 2025
@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh merged commit c3fcc3d into NVIDIA:main Jan 22, 2025
20 checks passed
@YuanTingHsieh YuanTingHsieh deleted the disable_ha_and_fix_ci branch January 22, 2025 18:41
@YuanTingHsieh YuanTingHsieh mentioned this pull request Jan 23, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@yanchengnv yanchengnv Awaiting requested review from yanchengnv

@SYangster SYangster Awaiting requested review from SYangster

@nvidianz nvidianz Awaiting requested review from nvidianz

Assignees
No one assigned
Labels
cicd continuous integration/continuous development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YuanTingHsieh @chesterxgchen @SYangster