Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance launcher executor #2744

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Enhance launcher executor #2744

merged 3 commits into from
Jan 21, 2025

Conversation

YuanTingHsieh
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh commented Jul 30, 2024 •
edited
Loading

Description

  • Add clear of peer_is_up_or_dead
  • Enhance error messages
  • Change "train_with_evaluation" default value to False so we don't require user to return metrics

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh force-pushed the enhance_launcher_executor_and_subprocess_launcher branch from 02adcf3 to a16b814 Compare July 30, 2024 21:10
@YuanTingHsieh YuanTingHsieh changed the title Enhance launcher executor and subprocess launcher Enhance launcher executor Jul 30, 2024
@YuanTingHsieh YuanTingHsieh changed the title Enhance launcher executor [2.6] Enhance launcher executor Jul 30, 2024
yanchengnv
yanchengnv requested changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Please improve log message text.

nvflare/app_common/executors/launcher_executor.py Outdated Show resolved Hide resolved
nvflare/app_common/executors/launcher_executor.py Outdated Show resolved Hide resolved
nvflare/app_common/executors/launcher_executor.py Outdated Show resolved Hide resolved
@YuanTingHsieh YuanTingHsieh force-pushed the enhance_launcher_executor_and_subprocess_launcher branch from b5cb345 to a131bb1 Compare November 25, 2024 23:06
@YuanTingHsieh YuanTingHsieh changed the title [2.6] Enhance launcher executor Enhance launcher executor Nov 25, 2024
@YuanTingHsieh YuanTingHsieh force-pushed the enhance_launcher_executor_and_subprocess_launcher branch from a131bb1 to 1d8da0a Compare November 25, 2024 23:07
@YuanTingHsieh YuanTingHsieh force-pushed the enhance_launcher_executor_and_subprocess_launcher branch from c9ea854 to 2fc6acb Compare January 17, 2025 22:51
@YuanTingHsieh YuanTingHsieh force-pushed the enhance_launcher_executor_and_subprocess_launcher branch from 2fc6acb to 84c41e5 Compare January 17, 2025 23:45
@YuanTingHsieh YuanTingHsieh force-pushed the enhance_launcher_executor_and_subprocess_launcher branch from 84c41e5 to 141bcbb Compare January 17, 2025 23:49
yanchengnv
yanchengnv approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh merged commit 7bcbafb into NVIDIA:main Jan 21, 2025
20 checks passed
@YuanTingHsieh YuanTingHsieh deleted the enhance_launcher_executor_and_subprocess_launcher branch January 21, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanchengnv yanchengnv yanchengnv approved these changes

@SYangster SYangster Awaiting requested review from SYangster

@nvidianz nvidianz Awaiting requested review from nvidianz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuanTingHsieh @yanchengnv