Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated flag xla_gpu_enable_triton_softmax_fusion. #1240

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Remove deprecated flag xla_gpu_enable_triton_softmax_fusion. #1240

merged 1 commit into from
Jan 21, 2025

Conversation

sergachev
Copy link
Contributor

@sergachev sergachev requested a review from nouiz January 10, 2025 17:10
@nouiz
Copy link
Collaborator

nouiz commented Jan 14, 2025

@DwarKapex does the CI results tell we can merge?

@sergachev
Copy link
Contributor Author

The flag was removed completely and will be causing failures: openxla/xla@e3ee51f

@olupton
Copy link
Collaborator

olupton commented Jan 21, 2025

The flag was removed completely and will be causing failures: openxla/xla@e3ee51f

Merging based on this. I do not think the CI here is sensitive to this.

@olupton olupton merged commit 22c2577 into main Jan 21, 2025
199 of 218 checks passed
@olupton olupton deleted the triton_softmax_fusion_flag branch January 21, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DwarKapex DwarKapex DwarKapex approved these changes

@olupton olupton olupton approved these changes

@nouiz nouiz Awaiting requested review from nouiz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sergachev @nouiz @olupton @DwarKapex