-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add position page #3
base: main
Are you sure you want to change the base?
Add position page #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we try to follow the figma more closely, perhaps move the back to all roles up, make overview and application wider, and change the font of UI/UX Designer and all.
Thank you!
</form> | ||
) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also have a placeholder Submit button? Thank you!
src/app/positions/page.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this, I'll request for a design from the designers!
Changes
positions
route, including the main route (/positions
) and its slug (/positions/[position name]
e.g.positions/ui-ux-designer
).@app/positions/not-found.tsx
in case the user clicks on undefined routes.Placeholders
@lib/positions/job-data.tsx
: this file stores all relevant texts (title, department, semester, description, ... ) into one dictionaryJobData
. (It's one of the simpliest way. You can change it later if you want.)@components/Navbar.tsx
and@components/Footer.tsx
@app/positions/pages.tsx
: temporarily use to display all routes fromJobData
(This is obviously a draft, not an actual version.)Previews