Add position page #3
Open
+343
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UpdatesI've temporarily add the landing page. (The route is |
nathanshew
requested changes
Oct 25, 2024
There was a problem hiding this comment.
Could we try to follow the figma more closely, perhaps move the back to all roles up, make overview and application wider, and change the font of UI/UX Designer and all.
Thank you!
| </form> | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
Could we also have a placeholder Submit button? Thank you!
src/app/positions/page.tsx
Outdated
There was a problem hiding this comment.
For this, I'll request for a design from the designers!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
positionsroute, including the main route (/positions) and its slug (/positions/[position name]e.g.positions/ui-ux-designer).@app/positions/not-found.tsxin case the user clicks on undefined routes.Placeholders
@lib/positions/job-data.tsx: this file stores all relevant texts (title, department, semester, description, ... ) into one dictionaryJobData. (It's one of the simpliest way. You can change it later if you want.)@components/Navbar.tsxand@components/Footer.tsx@app/positions/pages.tsx: temporarily use to display all routes fromJobData(This is obviously a draft, not an actual version.)Previews