Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LakeshoreIOC #67

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

LakeshoreIOC #67

wants to merge 6 commits into from

Conversation

malitsky
Copy link

No description provided.

@codecov-io
Copy link

codecov-io commented May 23, 2019

Codecov Report

Merging #67 into master will increase coverage by 3.32%.
The diff coverage is 99.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   52.16%   55.49%   +3.32%     
==========================================
  Files          11       10       -1     
  Lines         692      737      +45     
==========================================
+ Hits          361      409      +48     
+ Misses        331      328       -3
Impacted Files Coverage Δ
nslsii/tests/test_epstwostate_ioc.py 100% <ø> (ø)
nslsii/tests/lakeshore_test.py 99.19% <99.19%> (ø)
nslsii/temperature_controllers.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd076a7...7834bcb. Read the comment docs.

Copy link
Contributor

@awalter-bnl awalter-bnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, nice work implementing the damped-sin path for the readback temperatures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants