Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CLI to bypass required flag "--beamline" if specified in env #190

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Kezzsim
Copy link
Collaborator

@Kezzsim Kezzsim commented Aug 7, 2024

Resolves #189 by adding additional parsing logic to the CLI component which will get the beamline from the environment variable BEAMLINE_ACRONYM.

Some design consciderations:

  • This is implemented in the CLI args parser section as to allow the user to still override the env var with an argument if needed, this seems like it would be more intuitive.
  • Because of this decision, when invoking the function from within another python program; beamline will still need to be provided. This shouldn't be a huge deal because python scripting is automated and will be run by the machine and not a human. This entire endeavor is an ergonomic concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use BEAMLINE_ACRONYM as default
2 participants