Assign <blank> instead of, e.g., 0 to mean unused #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…7c433fc ac06a7c433fc Unrelated minor code cleanup. ce9220d3df9e Update argument descriptions [ci skip] 30dcd872f910 More optional arguments. Remove WWR arguments; fold functionality into the other window area arguments. c80ce936a854 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into optional-build-args 76951e1802ad Merge pull request #1868 from NREL/cfis_refactor 3d7ff588cf88 Latest results. 724ca3769a95 Update tests, final cleanup. fd0b299af2b5 Update changelog [ci skip] 99e0201a4f27 update measure.xml 58ef08bb1544 Indent. d32fcfa62102 Bugfix when no outdoor air control. be95d7ddd9d1 Bugfix for SupplementalFanRunsWithAirHandlerFan=true. Rename variables for clarity. d86c05086a61 Introduce ZoneTimestep into calculations. 8893f6b5b38f Bugfix. 1f5a98e1b414 Initial pass. Still need to resolve one diff and test further w/ shorter timesteps. 2cba857ee212 Remove ignored arguments from template osw file. ef2e09febbeb Remove ignored arguments from build measure test file. db5a8d77151f Merge branch 'master' into optional-build-args 9e0f85fbccb8 Merge pull request #1866 from NREL/cfis_control_type b7efd03d1f6e Increase docs width [ci skip] 719024e3e35e Change several arguments from required to optional, and start to clean up hpxml_inputs.json. c342b13d3ee1 Latest results. 46be375a885d Update tests 55918cd0680a Update changelog 24b5081d176a First pass on adding CFIS ControlType input. git-subtree-dir: resources/hpxml-measures git-subtree-split: ac06a7c433fc3285c1d6dc258e6e8d28e36e7b18
10 tasks
…lank argument value.
…5329b45 06f625329b45 Merge branch 'optional-build-args' of github.com:NREL/OpenStudio-HPXML into optional-build-args ef3dde21ba3e Merge branch 'master' into optional-build-args 1d56ca3cac1f Merge pull request #1872 from NREL/fix_dl_detailed_results 4d4fc470662d Add test. 94ddd8329aa3 Bugfix. 36350b91e004 Fixes possibility of missing surfaces in the results_design_load_details.csv output file. Bug introduced in #1836. ac06a7c433fc Unrelated minor code cleanup. ce9220d3df9e Update argument descriptions [ci skip] 30dcd872f910 More optional arguments. Remove WWR arguments; fold functionality into the other window area arguments. c80ce936a854 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into optional-build-args 2cba857ee212 Remove ignored arguments from template osw file. ef2e09febbeb Remove ignored arguments from build measure test file. db5a8d77151f Merge branch 'master' into optional-build-args 719024e3e35e Change several arguments from required to optional, and start to clean up hpxml_inputs.json. git-subtree-dir: resources/hpxml-measures git-subtree-split: 06f625329b450a1961f62cce88a7aca2f275aacd
…62034ce 9fc0362034ce Try a few more auto arguments in sample file. 14a489618b3f More entries to defaultOptionalArgumentValues. 4790ba244afc Start method for defaulting optional argument values. dba3891e5a86 Clean up. 1b60e912c164 Sweep through. 775eb161969e Progress. 5ac725251ce3 Progress. 6a64ad1b3a14 Latest results. 18716e8f18e6 Few more spots where a string is expected for argument values that can be comma-separated. bc1232c33620 Handle and test what happens when auto is provided. 00129ab007b2 Method for converting string arguments back to appropriate data type. ec7212799d97 Merge branch 'master' into optional-build-args 2f7c47554c5d Merge pull request #1876 from NREL/pthp_cfis bc1edd7f18ad Add unit test. [ci skip] 6c1b7408fc89 Latest results. d8ae938c2d99 A little more [ci skip] 4e8dfbaea2d0 More clarification in docs [ci skip] c8be1968424d Fix docs. b0816f8737c0 Allow CFIS systems to be attached to, e.g., PTHPs and PTACs. 5efc333d5574 Reorganize a bit. 0b5478d8d70c Handle double and integer arguments to string arguments when OS-HPXML default is used. 7f136a26071a Merge branch 'master' into optional-build-args 62e6fc80ccb7 Try logic for adding auto choice for bool and choice arguments with defaults. 54c542e52b76 Use named arguments and reformat, introduce default_href. ce0b009982ec Merge pull request #1815 from NREL/os390 c07ebb2c47f0 Stub generic makeArgument method. b21b555350c0 Update CI 25d02cff9e0c Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into os390 5075a608430b Typo in hvac_perf_data_capacity_type argument. 06f625329b45 Merge branch 'optional-build-args' of github.com:NREL/OpenStudio-HPXML into optional-build-args ef3dde21ba3e Merge branch 'master' into optional-build-args 57d1cf7b068e Merge pull request #1699 from NREL/window_component_loads 3e275044be3d Latest results. 20a4d18eba78 Merge branch 'os390' of https://github.com/NREL/OpenStudio-HPXML into window_component_loads 6a2d473483ec Merge pull request #1830 from NREL/os390_keep_site 8843d6cd809c Latest results. ce5a5e214081 Merge branch 'os390' of https://github.com/NREL/OpenStudio-HPXML into os390_keep_site 6372cb05db6c Latest results. fcc71e3e63af Try again 11f1c971370e Try manual OS docker build w/ E+ 24.2 3be703b42dfe Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into os390 ac06a7c433fc Unrelated minor code cleanup. ce9220d3df9e Update argument descriptions [ci skip] 30dcd872f910 More optional arguments. Remove WWR arguments; fold functionality into the other window area arguments. c80ce936a854 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into optional-build-args 2cba857ee212 Remove ignored arguments from template osw file. ef2e09febbeb Remove ignored arguments from build measure test file. db5a8d77151f Merge branch 'master' into optional-build-args 719024e3e35e Change several arguments from required to optional, and start to clean up hpxml_inputs.json. 7b5ec04f785d Shouldn't need this anymore [ci skip] 9f2a57e98486 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into os390 c4b533bde7cd Clarify variable [ci skip] 0170f0a6764d Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into os390 d3460f0cb6d1 Set keep site location information. [ci skip] 11be4d225966 update measure [ci skip] 1ee8c03d3fb6 Merge branch 'os390' of https://github.com/NREL/OpenStudio-HPXML into window_component_loads 544bd907d45b Update expected simulation message. [ci skip] 2a707115edfd Update docs [ci skip] 5f075ca252a5 Update Changelog [ci skip] b4aa2b439d22 Update to OS 3.9.0 [ci skip] 5382bf116cfc Improves window component load calculation, uses EnergyPlus improvements in NREL/EnergyPlus#10444. git-subtree-dir: resources/hpxml-measures git-subtree-split: 9fc0362034ce3c7870ebca574c0093c49e37a9a5
…5b41ea4 2f31f5b41ea4 More default values for previously required arguments. ca1885ec2476 Defaults for optional garage arguments. git-subtree-dir: resources/hpxml-measures git-subtree-split: 2f31f5b41ea46fa12461188bd5890e85a822fff7
…515d4a3 6e3bb515d4a3 Make convertArguments generic so we can use in resstock. git-subtree-dir: resources/hpxml-measures git-subtree-split: 6e3bb515d4a3156e0d34a2074a78e3ef4ce3ffa7
…3e4dc03 2f4903e4dc03 More default values for previously required arguments. git-subtree-dir: resources/hpxml-measures git-subtree-split: 2f4903e4dc03006963265351138623376047e1a4
…201d206 103a8201d206 Fix integer conversion in new method. 1ae24ade1875 Check zip code for lead zero. b03fd83572a7 Update template osw file. 2f4903e4dc03 More default values for previously required arguments. 6e3bb515d4a3 Make convertArguments generic so we can use in resstock. 2f31f5b41ea4 More default values for previously required arguments. ca1885ec2476 Defaults for optional garage arguments. 9fc0362034ce Try a few more auto arguments in sample file. 14a489618b3f More entries to defaultOptionalArgumentValues. 4790ba244afc Start method for defaulting optional argument values. dba3891e5a86 Clean up. 1b60e912c164 Sweep through. 775eb161969e Progress. 5ac725251ce3 Progress. 6a64ad1b3a14 Latest results. 18716e8f18e6 Few more spots where a string is expected for argument values that can be comma-separated. bc1232c33620 Handle and test what happens when auto is provided. 00129ab007b2 Method for converting string arguments back to appropriate data type. ec7212799d97 Merge branch 'master' into optional-build-args 5efc333d5574 Reorganize a bit. 0b5478d8d70c Handle double and integer arguments to string arguments when OS-HPXML default is used. 7f136a26071a Merge branch 'master' into optional-build-args 62e6fc80ccb7 Try logic for adding auto choice for bool and choice arguments with defaults. 54c542e52b76 Use named arguments and reformat, introduce default_href. c07ebb2c47f0 Stub generic makeArgument method. 5075a608430b Typo in hvac_perf_data_capacity_type argument. 06f625329b45 Merge branch 'optional-build-args' of github.com:NREL/OpenStudio-HPXML into optional-build-args ef3dde21ba3e Merge branch 'master' into optional-build-args ac06a7c433fc Unrelated minor code cleanup. ce9220d3df9e Update argument descriptions [ci skip] 30dcd872f910 More optional arguments. Remove WWR arguments; fold functionality into the other window area arguments. c80ce936a854 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into optional-build-args 2cba857ee212 Remove ignored arguments from template osw file. ef2e09febbeb Remove ignored arguments from build measure test file. db5a8d77151f Merge branch 'master' into optional-build-args 719024e3e35e Change several arguments from required to optional, and start to clean up hpxml_inputs.json. git-subtree-dir: resources/hpxml-measures git-subtree-split: 103a8201d206de85c2bf5f4e22257c6b6d06f7f3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
It's confusing to assign 0 to an argument to mean unused. So we'll set values to
<blank>for unused arguments.It's no longer possible to use "auto" to mean unused; "auto" can only mean "use OS-HPXML default".
Dehumidifier
Before
After
Related Pull Requests
OS-HPXML: NREL/OpenStudio-HPXML#1867.
Supersedes #1312.
Related Issues
Closes #1289.
Closes #1293.
Checklist
Required:
Optional (not all items may apply):
openstudio tasks.rb update_measureshas been run