Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update water heater location #1201

Merged
merged 26 commits into from
Feb 29, 2024
Merged

Update water heater location #1201

merged 26 commits into from
Feb 29, 2024

Conversation

lixiliu
Copy link
Contributor

@lixiliu lixiliu commented Jan 26, 2024

Pull Request Description

Move out-of-unit water heaters (i.e., Water Heater In Unit=No from Location=None to Location=Conditioned Mechanical Room (corresponds to OS-HPXML location: "other heated space").

Note:

  • Ideally out-of-unit WHs are modeled as shared centralized WHs, which have different pipe and tank losses than in-unit WH and would not have interactions with in-unit equipments such as HVAC. Central WH is not currently being modeled in ResStock, though that's changing soon with this PR and this PR.

  • Water Heater Location.tsv is currently a tag that's not connected to any ResStockMeasures. This means out-of-unit WHs are currently modeled as in-unit WHs. The revised location should remove the HVAC-HPWH interaction. But the pipe loss is still underestimated with in-unit WH models.

resstock-estimation PR: https://github.com/NREL/resstock-estimation/pull/395

Stats from test/base_results/baseline/annual/*:

Row Labels count Average of total_energy_mbtu Average of load_delivered_m_btu Average of tank_losses_m_btu
Attic 2 6.726 6.0515 0.462
Conditioned Mechanical Room 44 9.26368182 5.96754545 1.91309091
Crawlspace 2 5.1975 0.997 2.0995
Garage 63 9.81980952 6.40836508 2.08746032
Heated Basement 39 14.4264103 8.10228205 3.26838462
Living Space 151 10.8256424 6.41452318 2.21530464
Outside 8 11.867875 6.541625 2.964625
Unheated Basement 41 13.1755122 7.97468293 2.9404878

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

@lixiliu lixiliu changed the base branch from develop to ll/dwelling_unit_count January 26, 2024 17:25
@lixiliu lixiliu self-assigned this Jan 26, 2024
@lixiliu lixiliu force-pushed the ll/water_heater_location branch 2 times, most recently from d0f7e1a to 91840fa Compare January 26, 2024 19:10
@lixiliu lixiliu changed the base branch from ll/dwelling_unit_count to develop February 5, 2024 18:47
@afontani afontani merged commit 9f3ded1 into develop Feb 29, 2024
@joseph-robertson joseph-robertson deleted the ll/water_heater_location branch April 3, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants