-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update water heater location #1201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixiliu
force-pushed
the
ll/water_heater_location
branch
2 times, most recently
from
January 26, 2024 19:10
d0f7e1a
to
91840fa
Compare
lixiliu
force-pushed
the
ll/water_heater_location
branch
from
February 3, 2024 00:48
5f0e4c3
to
12dc3fb
Compare
lixiliu
force-pushed
the
ll/water_heater_location
branch
from
February 5, 2024 21:44
c7d1417
to
1ec57a8
Compare
lixiliu
force-pushed
the
ll/water_heater_location
branch
from
February 22, 2024 20:00
10aa121
to
c4c4968
Compare
lixiliu
force-pushed
the
ll/water_heater_location
branch
from
February 22, 2024 21:12
e7a2a23
to
bd5961a
Compare
afontani
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Move out-of-unit water heaters (i.e.,
Water Heater In Unit=No
from Location=None to Location=Conditioned Mechanical Room (corresponds to OS-HPXML location: "other heated space").Note:
Ideally out-of-unit WHs are modeled as shared centralized WHs, which have different pipe and tank losses than in-unit WH and would not have interactions with in-unit equipments such as HVAC. Central WH is not currently being modeled in ResStock, though that's changing soon with this PR and this PR.
Water Heater Location.tsv
is currently a tag that's not connected to any ResStockMeasures. This means out-of-unit WHs are currently modeled as in-unit WHs. The revised location should remove the HVAC-HPWH interaction. But the pipe loss is still underestimated with in-unit WH models.resstock-estimation PR: https://github.com/NREL/resstock-estimation/pull/395
Stats from test/base_results/baseline/annual/*:
Checklist
Not all may apply:
openstudio tasks.rb update_measures
has been run