-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to the workflow_inputs section of RTD #1193
base: develop
Are you sure you want to change the base?
Conversation
f776b4e
to
882d03d
Compare
@lixiliu : Thinking about this a little. I have a few thoughts:
Let me know what path you prefer. |
Summary of our discussion offline: The table is meant as a lookup for |
…o ll/dwelling_unit_count
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move the documentation to the Read-the-Docs instead of the Readme?
Leave emissions and utility bills to a future PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the plan/status for this PR?
Should we open a new ticket for addressing the Emissions and Utility Bills updates in the future? (Note that the Workflow Outputs section already contains Emissions and Utility Bills subsections.)
<<<<<<< HEAD | ||
- Add Census dwelling unit count by state table in resstock/resources/ folder ([#1193](https://github.com/NREL/resstock/pull/1193)) | ||
======= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some merge conflicts going on here.
@@ -1,6 +1,6 @@ | |||
.. _housing_characteristics: | |||
|
|||
Housing Characteristics | |||
Housing Characteristics Distributions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to make this change instead in docs/read_the_docs/source/workflow_inputs/create_characteristics_rst.rb
-- this script automatically generates characteristics.rst.
Pull Request Description
This PR updates the RTD
workflow_inputs
documentation. The section now specifically provides resources for:num_buildings_represented
This PR removes details about modifying and writing TSVs as this is done automatically in the resstock-estimation repository.
Checklist
Not all may apply:
- [ ] Tests (and test files) have been updated- [ ] If related to resstock-estimation, checklist includes data dictionary, source report, options saturation, options_lookup.- [ ]openstudio tasks.rb update_measures
has been run- [ ] No unexpected regression test changes on CI (checked comparison artifacts)