Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing use of foo=0 for unused variables in options_lookup.tsv #1293

Open
shorowit opened this issue Aug 27, 2024 · 2 comments · May be fixed by #1316
Open

Confusing use of foo=0 for unused variables in options_lookup.tsv #1293

shorowit opened this issue Aug 27, 2024 · 2 comments · May be fixed by #1316

Comments

@shorowit
Copy link
Contributor

ResStock uses foo=0 when a variable does not apply in options_lookup.tsv. That is confusing because there's no way to really differentiate between a variable that is using zero vs a variable that is not being used.

Can we change those that are not used to something like foo=na? (Or simply foo=?)

@joseph-robertson
Copy link
Contributor

Is this a duplicate of #1289?

@shorowit
Copy link
Contributor Author

shorowit commented Oct 15, 2024

For example, this could cause a bug unless specifically handled when NREL/OpenStudio-HPXML#1857 is pulled in. See here for more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants