-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MIT yaw correction model (3rd pass) #924
Open
jaimeliew1
wants to merge
15
commits into
NREL:develop
Choose a base branch
from
jaimeliew1:jaime
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+994
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you @jaimeliew1 for this exciting contribution! We'll start working on the review/merge soon! |
This was referenced Jul 22, 2024
A summary of changes I've made:
Notes / suggestions:
|
@jaimeliew1 I wasn't able to understand where mit_rotor_axial_induction and mit_rotor_velocity_yaw_correction are described in the paper. Could you explain this portion a bit more? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MIT yaw correction model (3rd pass)
This pull request implements an interpretation of the yawed actuator disk as described in Heck et al. (2023):
https://www.cambridge.org/core/journals/journal-of-fluid-mechanics/article/modelling-the-induction-thrust-and-power-of-a-yawmisaligned-actuator-disk/3A34FC48A6BC52A78B6D221C13F4FC3A
The method assumes that$C_T'$ is invariant to yaw misalignment (an assumption still to be verified), and preforms a wind speed reduction based on the model equations.
Related issue
The structure of the code changes resembles those in the previous pull request (#638) , but now compatible with Floris V4.
Another older pull request can be found here (#624)
Impacted areas of the software
A new operation model is added
mit_loss
(name to be decided).I added the code used to calculate the MIT operational model to
floris/core/mit_models
, but please move this to wherever you think is best.Additional supporting information
An example has been modified to show the operational models at different controller operation points. The added model is able to transition from below-rated to above-rated wind speeds in a realistic manner as shown in the following figure. I.e. The power output is "clipped" near rated wind speed, and is invariant to yaw far above rated wind speed.
Test results, if applicable
Relevant tests are still to be added.