[BUGFIX] Include turbulence_intensities in turbine_previewer.py #900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging #888 , the deployment of the documentation failed because one of the documentation notebooks calls methods on the
TurbineInterface
class, which I had missed when passing theturbulence_intensities
keyword argument to calls topower()
andthrust_coefficient()
. This fixes that problem.Perhaps a bigger issue is that
TurbineInterface
does not seem to be covered by tests and examples (it is only used in the documentation). I've opened #901 to discuss.Note that here, for simplicity, I'm passing 0 in for
turbulence_intensities
. That works, for now, because turbulence intensity is anyway not used in most operation models. However, if in future we expand the usage of theTurbineInterface
class to be more broadly compatible with operation models, we may want to addturbulence_intensities
as an input to some of the methods (so that, if an operation model whose output depends on the turbulence intensity is used, that dependency can be demonstrated).