Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Include turbulence_intensities in turbine_previewer.py #900

Merged
merged 1 commit into from
May 8, 2024

Conversation

misi9170
Copy link
Collaborator

@misi9170 misi9170 commented May 6, 2024

When merging #888 , the deployment of the documentation failed because one of the documentation notebooks calls methods on the TurbineInterface class, which I had missed when passing the turbulence_intensities keyword argument to calls to power() and thrust_coefficient(). This fixes that problem.

Perhaps a bigger issue is that TurbineInterface does not seem to be covered by tests and examples (it is only used in the documentation). I've opened #901 to discuss.

Note that here, for simplicity, I'm passing 0 in for turbulence_intensities. That works, for now, because turbulence intensity is anyway not used in most operation models. However, if in future we expand the usage of the TurbineInterface class to be more broadly compatible with operation models, we may want to add turbulence_intensities as an input to some of the methods (so that, if an operation model whose output depends on the turbulence intensity is used, that dependency can be demonstrated).

@misi9170 misi9170 added bug Something isn't working documentation labels May 6, 2024
@misi9170 misi9170 changed the title [BUGFIX] Include turbulence_intensities in turbine_preview.py [BUGFIX] Include turbulence_intensities in turbine_previewer.py May 6, 2024
@misi9170 misi9170 requested a review from rafmudaf May 6, 2024 21:22
@misi9170 misi9170 merged commit 19b018d into NREL:develop May 8, 2024
8 checks passed
@misi9170 misi9170 deleted the bugfix/peak-shaving-op branch May 8, 2024 13:39
@misi9170 misi9170 mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants