Skip to content

Commit

Permalink
Test on all supported Python versions (#1019)
Browse files Browse the repository at this point in the history
* Test on all supported Python versions

Pages build and speed check are on the latest version only

* Support Python 3.8

The pip to merge dicts is supported in Python 3.9+; replace with the dict.update method
  • Loading branch information
rafmudaf authored Nov 15, 2024
1 parent 4685e50 commit 92141ef
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/check-working-examples.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
python-version: ["3.9", "3.10", "3.11"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
os: [ubuntu-latest] #, macos-latest, windows-latest]
fail-fast: False

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/continuous-integration-workflow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
os: [ubuntu-latest] #, macos-latest, windows-latest]
fail-fast: False
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy-pages.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: "3.10"
python-version: "3.13"

- name: Install dependencies
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/quality-metrics-workflow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
python-version: ["3.10"]
python-version: ["3.13"]
os: [ubuntu-latest]
fail-fast: False

Expand Down
5 changes: 3 additions & 2 deletions floris/flow_visualization.py
Original file line number Diff line number Diff line change
Expand Up @@ -760,8 +760,9 @@ def add_ref_lines(
'color': 'k',
'linewidth': 1.1
}
kwargs = default_params | kwargs
params = copy.deepcopy(default_params)
params.update(kwargs)

for ax in self.axs[row]:
for coordinate in ref_lines_D:
ax.plot([0.0, 1.0], [coordinate, coordinate], **kwargs)
ax.plot([0.0, 1.0], [coordinate, coordinate], **params)

0 comments on commit 92141ef

Please sign in to comment.