Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix simdrivelabel discrepancy for EVs #77

Draft
wants to merge 4 commits into
base: fastsim-2
Choose a base branch
from
Draft

Fix simdrivelabel discrepancy for EVs #77

wants to merge 4 commits into from

Conversation

kylecarow
Copy link
Collaborator

  • fix bug with simdrivelabel EVs
  • enhance tests for simdrivelabel so that every vehicle type is tested

@kylecarow kylecarow self-assigned this Dec 6, 2023
@kylecarow
Copy link
Collaborator Author

@calbaker I cherry-picked the bug fix into fastsim-2 by the way, so this PR should just be your test changes now.

@kylecarow kylecarow requested review from calbaker and removed request for calbaker December 7, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakeholden jakeholden Awaiting requested review from jakeholden

@calbaker calbaker Awaiting requested review from calbaker

At least 1 approving review is required to merge this pull request.

Assignees

@kylecarow kylecarow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarow @calbaker