Refactor RustCycle constructors #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
kylecarow
force-pushed
the
refactor-cycle-constructor
branch
from
9f61ed5
to
dff05f8
Compare
calbaker
reviewed
Dec 1, 2023
calbaker
reviewed
Dec 1, 2023
| @@ -226,13 +227,14 @@ pub fn main() -> anyhow::Result<()> { | |||
| RustCycle::from_file(adopt_hd_string) | |||
| } else { | |||
| //TODO? use pathbuff to string, for robustness | |||
There was a problem hiding this comment.
@kylecarow , is this comment deprecated here?
There was a problem hiding this comment.
Not sure, that's leftover from Andrew Guttman. I think we could delete the TODO.
|
@calbaker This is ready to merge BTW |
calbaker
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RustCycle::newandRustCycle.__new__namefield)