Dummy PR: changed to drag_coef: VehicleField<f64>
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some tests fail but most pass despite having `std::ops::Mul` implemented, requires unwieldy use of `clone()` method to satisfy borrow checker
calbaker
commented
Aug 10, 2023
| @@ -332,8 +332,9 @@ impl RustSimDrive { | |||
| }; | |||
| let g = self.props.a_grav_mps2; | |||
| let m = self.veh.veh_kg; | |||
| let rho_cdfa = | |||
| self.props.air_density_kg_per_m3 * self.veh.drag_coef * self.veh.frontal_area_m2; | |||
| let rho_cdfa = self.veh.drag_coef.clone() | |||
There was a problem hiding this comment.
@kylecarow , VehiclField<f64> can be multiplied by f64 but not the other order. Because types that are used in math operations normally implement the std::markers::Copy trait and VehicleField<f64> cannot implement that trait due to fields that can't do it, we need to use .clone() a lot, which in my mind negates the benefit of the std::ops implementations.
calbaker
commented
Aug 10, 2023
| @@ -180,6 +183,130 @@ impl CostFunction for GetError<'_> { | |||
| } | |||
| } | |||
|
|
|||
| macro_rules! array_and_scalar_ops { | |||
There was a problem hiding this comment.
@kylecarow , this is where I've implemented the std::ops traits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some tests fail but most pass
despite having
std::ops::Mulimplemented, requires unwieldy use ofclone()method to satisfy borrow checker