Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports from traitlets #429

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Remove unused imports from traitlets #429

merged 1 commit into from
Nov 15, 2023

Conversation

vtnate
Copy link
Contributor

@vtnate vtnate commented Nov 8, 2023

Resolves #426

2 methods were being imported from traitlets that are unused. Removing them reduces the risk surface, enabling a more stable package.

If these are actually required, please let me know where they are used and I will close this PR.

@tarekelgindy tarekelgindy merged commit ddd81a1 into NREL:master Nov 15, 2023
9 checks passed
@vtnate vtnate deleted the remove-traitlets-import branch November 15, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Probably shouldn't import private methods from other packages
2 participants