-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gridlabd datamodel with common DiTTo reader #349
base: kd/gridlabd-datamodel
Are you sure you want to change the base?
Gridlabd datamodel with common DiTTo reader #349
Conversation
|
||
import enum | ||
|
||
class SimulationEngine(enum.Enum): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may not be required.
""" | ||
|
||
@abc.abstractmethod | ||
def read_dataset(self, path, model, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions on better terminology are welcome.
My understanding of this proposal is that we are
@daniel-thom feel free to correct me if I'm misinterpreting or omitting certain pieces. |
From talking with Dheepak I don't think it will be practical to remove storage of the This still could be bad for two reasons:
Just as a comment, I think the code would be easier to reason about if the |
This integrates the datamodel that Dheepak created with a proposal for a new common reader.
The main new concept here is this:
ditto.readers.reader.DiTToReader
is responsible for controlling the parsing process.DiTToReader
creates a reader interface for the simulation engine specified by the inputs.ditto.readers.reader_interface.ReaderInterface
specifies the required methods for a reader.I think this design would be better if the
Store
object was not stored within each DiTTo model instance. I'm OK with keeping it like this.