Skip to content

Commit

Permalink
Still fetch config on initial app load.
Browse files Browse the repository at this point in the history
This is to help with the app not wanting to initialize the envoy control
plane until a request has been made, but we should go ahead and try to
populate config on app boot.
  • Loading branch information
GUI committed Sep 28, 2023
1 parent 634d05d commit 7c4e422
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,6 @@ return function(cache, callback)
if last_fetched_version_err then
ngx.log(ngx.ERR, "Error fetching last_fetched_version: ", last_fetched_version_err)
return
elseif not last_fetched_version then
-- If the active config hasn't been set yet, then this means the first
-- fetch (triggered on demand by active_config_store.get) yet completed, so
-- return and wait for that to complete, since there's no need to poll for
-- a newer version with nothing stored yet.
return
end

-- If this set of worker processes hasn't been setup yet (initial boot or
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,6 @@ local function update_control_plane(active_config, clusters, listeners, route_co
write_control_plane_config_file("listener-" .. resource["name"] .. ".json", json_encode(resource))
end


write_control_plane_config_file("route-configuration.json", json_encode(route_configuration))

-- Remove any files from the data directory that shouldn't be there any
Expand Down

0 comments on commit 7c4e422

Please sign in to comment.